-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Java 17 #346
Conversation
Thanks for this @skylee03, I wasn't expecting this! I'm not sure why the Actions are not running. I'll try to find a way to run it, and if all the checks pass, then let's merge it! |
I'm going to try and close and reopen this as I changed some of the Actions config. |
@skylee03 I hope the failing test should be easy-ish to fix? Also, would you be happy to make the same |
👌 |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #346 +/- ##
=========================================
Coverage 99.839% 99.839%
=========================================
Files 36 36
Lines 3118 3118
Branches 4 4
=========================================
Hits 3113 3113
Misses 1 1
Partials 4 4 |
I found that some dependencies in |
Yes, please, if you could that, that would be fantastic, thanks! Happy to merge this after that. |
Thank you again for your contribution! I'll prepare a 0.0.41 release. |
--add-opens
JVM options to get rid of "cannot access class" errors