Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java 17 #346

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Conversation

skylee03
Copy link
Collaborator

  • Update Spark to 3.3.3
  • Specify Netty and Jackson versions
  • Add --add-opens JVM options to get rid of "cannot access class" errors
  • Update tests to adapt the output format of Spark 3.3.3

@skylee03 skylee03 marked this pull request as ready for review October 28, 2023 12:28
@anthony-khong
Copy link
Member

Thanks for this @skylee03, I wasn't expecting this! I'm not sure why the Actions are not running. I'll try to find a way to run it, and if all the checks pass, then let's merge it!

@anthony-khong anthony-khong self-assigned this Oct 28, 2023
@anthony-khong
Copy link
Member

I'm going to try and close and reopen this as I changed some of the Actions config.

@anthony-khong
Copy link
Member

@skylee03 I hope the failing test should be easy-ish to fix?

Also, would you be happy to make the same project.clj changes to the Lein template in lein-template/resources/leiningen/new/geni/project.clj as well?

@skylee03
Copy link
Collaborator Author

@skylee03 I hope the failing test should be easy-ish to fix?

Also, would you be happy to make the same project.clj changes to the Lein template in lein-template/resources/leiningen/new/geni/project.clj as well?

👌

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #346 (f87d3fd) into develop (b616f02) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #346   +/-   ##
=========================================
  Coverage   99.839%   99.839%           
=========================================
  Files           36        36           
  Lines         3118      3118           
  Branches         4         4           
=========================================
  Hits          3113      3113           
  Misses           1         1           
  Partials         4         4           

@skylee03
Copy link
Collaborator Author

skylee03 commented Oct 28, 2023

I found that some dependencies in lein-template/resources/leiningen/new/geni/project.clj are newer than those in project.clj. Should I also update the dependencies in project.clj to the same versions?

@anthony-khong
Copy link
Member

Yes, please, if you could that, that would be fantastic, thanks! Happy to merge this after that.

@anthony-khong anthony-khong merged commit 6a54e54 into zero-one-group:develop Oct 28, 2023
7 checks passed
@anthony-khong
Copy link
Member

Thank you again for your contribution! I'll prepare a 0.0.41 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants