samples: echo_client: fix rw612_openthread_rcp_host build in CI #82808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Sockets
zephyrbot
requested review from
jukkar,
kartben,
nashif,
pdgendt,
rlubos,
ssharks and
tbursztyka
axelnxp
force-pushed
the
fixup/echo_client_rw612_ot_rcp
branch
from
d213cb9 to
f9093f5
Compare
MONOLITHIC_NXP_NBU cannot be used in CI as it relies on firmware blobs to be fetched. Disabling the feature so the CI can pass. Also tagging this test as build_only. Signed-off-by: Axel Le Bourhis <[email protected]>
rlubos
approved these changes
Dec 10, 2024
dleach02
added
the
Hotfix
dleach02
approved these changes
Dec 10, 2024
kartben
approved these changes
Dec 10, 2024
fabiobaltieri
approved these changes
Dec 10, 2024
|
thanks for the quick turnaround folks |
|
Looks like echo_server needs a similar fix 😭 @axelnxp would be awesome if you could send a PR, unless someone else beats you to it, as I'm not in front of a computer right now. edit: done -- see #82832 |
@kartben sorry I was already out of the office, thanks for fixing ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONOLITHIC_NXP_NBU cannot be used in CI as it relies on firmware blobs to be fetched.
Disabling the feature so the CI can pass.
Also tagging this test as build_only.