bluetooth: tester: audio: Add NULL checks #82530
Open
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexsven
commented
Dec 4, 2024
alexsven
commented
- Add NULL checks for broadcast_source_stop
- Add NULL checks for broadcast_source_release
- Return -ESRCH if trying to stop ext_adv before creation
- Add NULL checks for broadcast_source_stop - Add NULL checks for broadcast_source_release - Return -ESRCH if trying to stop ext_adv before creation Signed-off-by: Alexander Svensen <[email protected]>
zephyrbot
added
area: Bluetooth
area: Bluetooth Audio
area: Bluetooth Qualification
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kruithofa,
larsgk,
MariuszSkamra,
niym-ot and
pin-zephyr
koffes
approved these changes
Dec 4, 2024
sjanc
approved these changes
Dec 4, 2024
Thalley
approved these changes
Dec 4, 2024
Comment on lines
+700
to
+703
| /* If no source has been created yet, there is nothing to release */ | ||
| if (source == NULL || source->cap_broadcast == NULL) { | ||
| return BTP_STATUS_SUCCESS; | ||
| } |
There was a problem hiding this comment.
@sjanc I think this is a missing part of the existing BTP documentation. The documentation only contain information about what the command and responses contain, but unlike e.g. the HCI specification, it does not describe the expected behavior of commands in error cases.
For example it seems that BlueKitchen will return success when removing or stopping a non-existing source, where Zephyr (until this PR) would return an error.
I think that if we want BTP to be a proper protocol, we need to start expanding with additional status codes as well as expected behavior, otherwise it's basically a guessing game for the DUT when implementing it if the autopts client expects undocumented behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.