drivers: serial: nrfx_uarte: Add requesting of HSFLL GD clock when fast UARTE (uart120) is used #82103
+212
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct :) |
hubertmis
previously approved these changes
Nov 27, 2024
When fast UARTE instance is used (e.g. UARTE120 in nrf54h20), PM actions are not ISR safe because they include communication over IPC so they can only be called from the thread context. Extend driver to support both PM modes. When non ISR mode is used then uart_rx_enable() and uart_tx() will return error if they are called from ISR and resume operation would need to be called because device is suspended. On completion, driver is calling pm_device_runtime_put_async which can be called from the ISR context. Additionally, suspending in the TXSTOPPED and RXTO events has been moved after user callback. It allows to support the case where uart_rx_enable() or uart_tx() are called from that callback context. Since suspending is called after returning from the callback it will not trigger suspend action because API called in the callback context will increment the usage counter (when pm_device_runtime_get() is called). Signed-off-by: Krzysztof Chruściński <[email protected]>
Request fast global domain to run at 320 MHz during fast UARTE activity. As request is asynchronous it cannot be called from an ISR. Due to complexity to handle that without device runtime power management a requirement is added so that if fast UARTE is used device runtime PM must be enabled. Clock is request and released in PM resume and suspended actions which in case of fast UARTE are only called from thread context. Signed-off-by: Krzysztof Chruściński <[email protected]>
Enable device runtime PM for nrf54h20dk/nrf54h20/cpuapp where fast UARTE (uart120) is tested. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
uart_hsfll
branch
from
42b2610
to
d634eee
Compare
zephyrbot
added
platform: nRF
zephyrbot
requested review from
anangl,
dcpleung,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clock request and release in resume and suspend actions. It is required for the fast UARTE peripheral (uart120 in nrf54h20). Since it would be tricky to handle that outside of PM actions added build time check which enforces use of device runtime PM when fast UARTE is used (device power PM is de facto a must in nrf54h20 so it is not a real limitation).
Due to device runtime PM requirement,
uart_async_apitest configuration for nrf54h20dk/nrf54h20/cpuapp has been extended to enable PM.Work from PR #81527 had to be included.
DNM until #81735.