-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating dedicated memory pools for data and control traffic #78588
base: main
Are you sure you want to change the base?
Conversation
Create dedicated memory pools for Wi-Fi management and data operations (defaults: 20KB for management and 60KB for data). Reduce the heap memory pool size since the Wi-Fi driver will be allocating memory from a dedicated pool. Signed-off-by: Ravi Dondaputi <[email protected]>
Pull changes for creating separate memory pools for control traffic and data traffic. Signed-off-by: Ravi Dondaputi <[email protected]>
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
@@ -541,6 +541,15 @@ config NRF70_RSSI_STALE_TIMEOUT_MS | |||
|
|||
if NETWORKING | |||
# Finetune defaults for certain system components used by the driver | |||
|
|||
config NRF_WIFI_CTRL_HEAP_SIZE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order to leverage the newly added per-module HEAP hints, may be we should use HEAP_MEM_POOL_ADD_SIZE_NRF70_CTRL
and HEAP_MEM_POOL_ADD_SIZE_NRF70_DATA
, this way there won't be any changes to the samples/applications. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are creating a separate pool for each of the control path and data path, and not allocating from system heap. Since HEAP_MEM_POOL_ADD_SIZE_*
is used just as a hint to verify the available system heap, using this name convention here may not be appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then existing HEAP_MEM_POOL_ADD_SIZE_
have to be removed or reduced, no? And then for NRF_WIFI_DATA_HEAP_SIZE
needs to be adjusted per-sample as per the network buffer configuration?
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
No description provided.