Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwm2m interoperability tests #65482

Merged

Conversation

SeppoTakalo
Copy link
Collaborator

This PR implements previously missing testcases that were not supported by Leshan.

Now Leshan support is added, see eclipse-leshan/leshan#1537

Now we can pass all LwM2M interoperability tests in range 100 - 399.

To run these tests, you need to fetch latest Leshan .jar file. Easiest is to rebuild the existing net-tools docker image without cache docker build --no-cache -t net-tools .

This allows quick filtering with
pytest_args: ['-k not slow']

Signed-off-by: Seppo Takalo <[email protected]>
Implement write and remove attributes command for Leshan.
Remove all written attributes at the end of test, so it won't
affect the next test case.

Remove skip marks from testcase that is fixed on Leshan side.

Signed-off-by: Seppo Takalo <[email protected]>
Test case:
LightweightM2M-1.1-int-235 - Read-Composite Operation on root path
is now working as Leshan added a support for reading the root path.

Signed-off-by: Seppo Takalo <[email protected]>
Implement test cases:
LightweightM2M-1.1-int-303 - Cancel observations using Observe with
Cancel parameter

LightweightM2M-1.1-int-305 - Cancel Observation-Composite Operation

Modify existing Leshan API to passive_cancel().

Signed-off-by: Seppo Takalo <[email protected]>
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carlescufi carlescufi merged commit 31e9a56 into zephyrproject-rtos:main Nov 22, 2023
20 checks passed
@kartben
Copy link
Collaborator

kartben commented Nov 23, 2023

Hey guys, can you please make sure changes like these get properly reviewed? I.e. as per the "4-eye principle" there should be at least one person from another organization giving a +1...

@SeppoTakalo SeppoTakalo deleted the lwm2m_interoperability_tests branch November 23, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants