[SPARK-48136][INFRA][CONNECT] Always upload Spark Connect log files i…

…n scheduled build for Spark Connect

### What changes were proposed in this pull request?

This PR proposes to upload Spark Connect log files in scheduled build for Spark Connect

### Why are the changes needed?

Difficult to debug, e.g., https://github.com/apache/spark/actions/runs/8960485641/job/24607044822

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46393 from HyukjinKwon/SPARK-48136.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>

.github/workflows/build_python_connect.yml

@@ -118,7 +118,7 @@ jobs:
           name: test-results-spark-connect-python-only
           path: "**/target/test-reports/*.xml"
       - name: Upload Spark Connect server log file
-        if: failure()
+        if: ${{ !success() }}
         uses: actions/upload-artifact@v4
         with:
           name: unit-tests-log-spark-connect-python-only

.github/workflows/build_python_connect35.yml

@@ -106,7 +106,7 @@ jobs:
           name: test-results-spark-connect-python-only
           path: "**/target/test-reports/*.xml"
       - name: Upload Spark Connect server log file
-        if: failure()
+        if: ${{ !success() }}
         uses: actions/upload-artifact@v4
         with:
           name: unit-tests-log-spark-connect-python-only