Slice walking implementation #124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 74 74
Lines 247 259 +12
Branches 48 54 +6
=====================================
+ Hits 247 259 +12
Continue to review full report at Codecov.
|
nlepage
changed the title
nlepage
changed the title
nlepage
force-pushed
the
feature/94
branch
6 times, most recently
from
a37d9c7
to
bbb85da
Compare
|
This isn't WIP anymore, I think we can merge this. |
| const copyArray = array => { | ||
| if (array === undefined || array === null) return [] | ||
| if (isNil(array)) return [] |
| const [prop, ...pathRest] = curPath | ||
|
|
||
| const value = callback(curObj, prop) | ||
| if (isSlice(prop)) { |
|
|
||
| const newObj = copy(curObj, isArrayProp(prop)) | ||
| let newObj = curObj | ||
| if (doCopy) newObj = copy(curObj, isIndex(prop)) |
There was a problem hiding this comment.
When we are iterating on a slice, only one copy of the array is necessary, so this is to avoid several copies
| if (isSlice(prop)) { | ||
| const [start, end] = getSliceBounds(prop, length(curObj)) | ||
|
|
||
| const newArr = copy(curObj, true) |
There was a problem hiding this comment.
the second param is not clear. Usually the second param in a copy function is for deep not asArray
There was a problem hiding this comment.
As long as this is documented...
There was a problem hiding this comment.
And this is private code
…ly callback for now
| * @private | ||
| * @since 0.4.0 | ||
| */ | ||
| const getSliceBounds = ([start, end], length) => ([ |
| * @since 0.4.0 | ||
| */ | ||
| const length = arg => { | ||
| if (isNil(arg) || !isNaturalInteger(arg.length)) return 0 |
Description
Slice walking implementation
Issue : #94