Skip to content

Commit

Permalink
Close #487 - Update scala-library to 2.13.14
Browse files Browse the repository at this point in the history
  • Loading branch information
cchantep committed Aug 6, 2024
1 parent 0a54cc6 commit 38d01a3
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 17 deletions.
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ commands:
default: "openjdk8"
scala_version:
type: string
default: "2.13.12"
default: "2.13.14"
ws_version:
type: string
default: ""
Expand Down Expand Up @@ -121,7 +121,7 @@ commands:
default: "openjdk8"
scala_version:
type: string
default: "2.13.12"
default: "2.13.14"
ws_version:
type: string
default: ""
Expand Down Expand Up @@ -276,7 +276,7 @@ jobs:
- test_suite:
java_version: openjdk9
modules: core vfs play
scala_version: 2.13.12
scala_version: 2.13.14
ws_version: 2.1.2
play_version: 2.8.0
play_json_version: 2.8.1
Expand Down Expand Up @@ -377,7 +377,7 @@ jobs:
play_version: 2.7.1
play_json_version: 2.9.1
ws_version: 2.0.6
scala_versions: 2.13.12
scala_versions: 2.13.14

- publish_snapshots:
release_suffix: play28
Expand All @@ -392,7 +392,7 @@ jobs:
ws_version: 2.1.2
play_version: 2.8.0
play_json_version: 2.8.1
scala_versions: 2.13.12
scala_versions: 2.13.14

- save_cache:
paths:
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ThisBuild / scalaVersion := "2.12.19"
ThisBuild / crossScalaVersions := Seq(
"2.11.12",
scalaVersion.value,
"2.13.12",
"2.13.14",
"3.2.1"
)

Expand Down
19 changes: 9 additions & 10 deletions s3/src/main/scala/WSS3BucketRef.scala
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,15 @@ final class WSS3BucketRef private[s3] (
)(implicit
m: Materializer
): Future[Unit] = {
// We want to delete all versions including deleteMarkers for this bucket to be considered empty.
ObjectVersions()
.withDeleteMarkers()
.runFoldAsync(())((_: Unit, e) => {
// As we will delete all deleteMarkers we disable the auto-delete of deleteMarkers using "skipMarkersCheck"
obj(e.name, e.versionId)
.WSS3DeleteRequest()
.skipMarkersCheck
.ignoreIfNotExists()
})
// We want to delete all versions including deleteMarkers
// for this bucket to be considered empty.
ObjectVersions().withDeleteMarkers().runFoldAsync(()) { (_: Unit, e) =>
// As we will delete all deleteMarkers we disable
// the auto-delete of deleteMarkers using "skipMarkersCheck"
val objRef = obj(e.name, e.versionId)

objRef.WSS3DeleteRequest().skipMarkersCheck.ignoreIfNotExists()
}
}

def delete: DeleteRequest = WSS3DeleteRequest()
Expand Down
4 changes: 3 additions & 1 deletion s3/src/main/scala/WSS3VersionedObjectRef.scala
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ final class WSS3VersionedObjectRef(
): Future[Seq[VersionedObject]] = {
implicit val ec: ExecutionContext = m.executionContext

new WSS3ObjectRef(storage, bucket, name)
val objRef = new WSS3ObjectRef(storage, bucket, name)

objRef
.ObjectVersions()
.withDeleteMarkers
.collect[List]()
Expand Down

0 comments on commit 38d01a3

Please sign in to comment.