Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

[3.0] Mark static factories as deprecated #176

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

[3.0] Mark static factories as deprecated #176

wants to merge 11 commits into from

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 10, 2018

As requested in #175

@boesing
Created AdapterPluginManager polyfills for either `zend-servicemana…
b2a03e4 
…ger` v2 and v3
@boesing
Added stubs for polyfilled plugin managers
0186d9a
@boesing
Linked the polyfill classes in their stubs
d19f90e
@boesing
Fixed documentation issue
e5e6a61
@boesing
Marked Zend\Cache\StorageFactory and Zend\Cache\PatternFactory as…
76e1322 
… deprecated

- Piped `Zend\Cache\StorageFactory` logic to new `Zend\Cache\Storage\StorageFactory` which uses dependency injection instead of static methods
- Fixed unit tests for new PluginManager calls
- Trigger `E_USER_DEPRECATED` error on static factory calls
@boesing
Added missing file headers
0ddade2
@boesing
Fixed unit test after added E_USER_DEPRECATED error
50c2ffe
@boesing
Copy link
Member Author

boesing commented Sep 10, 2018

Need to add the new StorageFactory to the ServiceManager configuration. Reminder for myself.

@boesing
Copy link
Member Author

boesing commented Sep 11, 2018

Well, it looks like the pcntl_fork unit test for Filesystem fails in travis for PHP 7.2 lowest dependencies.
I am on PHP 7.2 locally and the unit tests wont fail. Any suggestions?

@Ocramius
Copy link
Member

Most likely unrelated to your changes

@boesing
Removed new StorageFactory
acd9edc 
- Moved plugin attachment logic into the `AdapterPluginManager`
- Restored most of the old static `StorageFactory` with minor enhancements
- Removed unit tests for new `StorageFactory`
- Added unit test for extended options for `AdapterPluginManager`
@boesing
Fix unit test has more than 120 chars in line warning...
c29ee81
@Ocramius Ocramius added this to the 2.9.0 milestone Sep 12, 2018
@boesing boesing changed the title [ZF3] Mark static factories as deprecated [3.0] Mark static factories as deprecated Nov 7, 2018
@michalbundyra michalbundyra modified the milestones: 2.9.0, 2.10.0 Aug 29, 2019
@weierophinney weierophinney mentioned this pull request Dec 31, 2019
Closed
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-cache; a new issue has been opened at laminas/laminas-cache#3.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-cache. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-cache to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-cache.
  • In your clone of laminas/laminas-cache, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@boesing @Ocramius @weierophinney @michalbundyra