refactor: Convert flatpak-manager into a module #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're only enabling the Flatpak-related services, and those are being converted into a separate module.
Unless this is made a bling module instead, this module is gonna have to work like yafti in that the necessary files need to be included in startingpoint directly.
zelikos
force-pushed
the
flatpak-manager-module
branch
from
3d08c9f to
8ddfb3a
Compare
Had them there for testing, don't need them to stay.
System-wide was flathub-system, per-user was flathub-user. I do like having it explicit like that myself, but for more general-purpose usage, it's probably best to keep it generic as just flathub for both. Flatpak does allow specifying --system or --user already, anyway.
Since I'm switching back to using "flathub" as the remote name instead of specifying -user vs -system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Prototyping this here before opening PRs upstream. Will need to do one in both startingpoint and bling