Support new sport dropdown #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Strava heatmap site has a new sport dropdown. And the mapping from the selected sport in the query parameters to the tiles url changed. It is now:
sportmap_typeSo in the first commit in this PR I wrote some new mapping logic to implement this.
I then noticed that using the
map_typevalue in the name for the layer in JOSM layer could be confusing. Who would guess that "run" means all foot sports and "sport_Run" means only running? So I changed the code to use thesportvalue in the name for the layer in JOSM. I think that one is easier to understand, here is a screenshot:Fixes #13.