Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks #60

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Add pre-commit hooks #60

merged 5 commits into from
Mar 1, 2024

Conversation

bbannier
Copy link
Member

This adds a number of formatters and linters.

@bbannier bbannier self-assigned this Feb 27, 2024
@bbannier bbannier marked this pull request as ready for review February 27, 2024 19:04
@bbannier bbannier requested a review from timwoj February 27, 2024 19:04
Copy link
Member

@timwoj timwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the line breaks added by prettier in the jinja templates might break things. Jinja can be a bit finnicky sometimes, in my prior experience.

@bbannier
Copy link
Member Author

Some of the line breaks added by prettier in the jinja templates might break things. Jinja can be a bit finnicky sometimes, in my prior experience.

I had tried to format the template HTML files with prettier and tried to manually back out problematic files, but I might have screwed up. I reverted this and now do not format any template files anymore (identified by their path which is excluded by pre-commit).

@timwoj timwoj merged commit 1a8c3b5 into main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants