Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

WIP Update to Camunda Modeler @next infrastructure #33

Merged
merged 306 commits into from
Jan 15, 2019
Merged

WIP Update to Camunda Modeler @next infrastructure #33

merged 306 commits into from
Jan 15, 2019

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Jan 15, 2019 •
edited
Loading

Relates to #32

🚧 Waits for Pre-Release.0 of camunda-modeler to be merged. 🚧

Tasks

  • Update to Camunda Modeler @next (b97626e, see commit history below)
  • Integrate Zeebe custom modules (baffe89)
  • Overall refactoring: ES6 support (3655906)
  • Setup and document a way to keep up-to-date with upstream Camunda Modeler (15adc9d)
  • Add / Improve test infrastructure (16f1e7b, 2e65a50, c6fb77f, 01dc6e7)
  • Add automated release and nightly builds

Note: With our newly created sync-fork task we are able to keep changes in the base modeler in sync with the Zeebe Modeler. Note that the commits chore(project): synchronize with base modeler are letting us now when this synchronizations were happening.

nikku and others added 30 commits November 30, 2018 23:57
@nikku
chore(ci): cache .npm directory
8901507
@nikku
feat(client/DropdownButton): allow child content
06d089a 
* accept items=Function
* render props.children as button body
@nikku
feat(client): add Icon primitive
307a3e6
@nikku
feat(client): use app icons
8d90a16
@nikku
feat(client): add Loader primitive
45da3b9
@nikku
chore(client/AppParent): use debug for logging
f3d1338
@nikku
feat(client/BpmnEditor): indicate diagram loading state
0eb3276
@nikku
fix(app/Toolbar): align items center
68cb001
@nikku
feat(client/BpmnEditor): style minimap toggle
a66d4a4
@nikku
test(client): adjust component test names
1740e7f
@nikku
fix(client/Toolbar): correct separator style
7850b88
@nikku
chore(client/App): generalize default actions
5bc8d85 
* pull out save, save-as, export, undo and redo as common actions
* pass full editor state to app
@nikku
test(client/App): stub test
3ea403b
@nikku
chore(client/App): add title
49e0864
@philippfromme @nikku
fix(client/DmnEditor): rename dirtyChanged -> onChanged
2b77af7
@philippfromme @nikku
feat(client): turn deploy button into dropdown button with icon
cbec4dc
@nikku
chore(client/App): make correctly wire DMN create actions
82445aa 
Closes #909
@philippfromme @nikku
feat(app): editors are responsible for edit menu
a5a3c48 
Related to #866
Closes #907
@philippfromme @nikku
fix(client/app): handle save cancelled by user
9600ad8
@philippfromme @nikku
chore(project): update .gitignore
2376c90 
* ignore .vscode directory which is necessary for debugging Electron with VS Code
@philippfromme @nikku
feat(client): add image export (svg, png, jpeg)
224bf72 
Closes #908
Related to #866
@philippfromme @nikku
feat(client/dmn-editor): attach properties panel
42f6731 
Related to #902
Related to #866
@philippfromme @nikku
feat(client): add image export to cmmn and dmn
a8276be 
Related to #866
@philippfromme @nikku
feat(client): errors (import/export/modeling) are escalated to app
7abb394 
Related to #896
@philippfromme @nikku
feat(client): add global layout
b0f4db0 
Related to #866
Related to #911
@philippfromme @nikku
fix(client): fix error handling
fe101b9 
Related to #866
@nikku
style(client): fix lint errors
3c16c6f
@nikku
fix(client): add missing canvg-browser dependency
578c4d3
@nikku
chore(project): rebuild package-lock
bb79f31
@philippfromme @nikku
feat(client): persist workspace
08a9376 
Related to #866
nikku and others added 21 commits January 14, 2019 15:16
@nikku
chore(dragger): prevent jumping
c93d552 
* ignore wrong initial drag coordinate
* reformat code
@barmac
chore(project): bump min-dash version
ac0487b
@barmac
fix(dragger): simplify dragger
49624a8 
* remove not used extraArgs feature
* use event listener `once` option to remove dragend listener
@barmac
fix(tab-links): update only on tabs change
a1d8e1d
@barmac
fix(tab): improve log and properties panel resize performance
d39f833 
This commit causes drag events to be throttled. Also, log and properties
panel will now create dragger only when actual drag is started.

Closes #1081
@barmac
feat(editors): resize properties panel along with editor
ece9776 
Closes #1080
@barmac
fix(empty-tab): add missing trigger action implementation
4bd035a
@barmac
feat(client): add window resize handler
ea42193 
Closes #1082
@philippfromme
fix(client): fix BpmnEditor import and dirty state
b0e151e
@philippfromme
fix(client): fix CmmnEditor import and dirty state
940d51b
@philippfromme
fix(client): fix XMLEditor import and dirty state
db12435
@philippfromme
fix(client): fix DmnEditor import and dirty state
de1a9a4
@philippfromme
fix(client): save XML on import
cb05699
@philippfromme
fix(client): correctly update state
108774f 
* avoid state updates getting lost
* add tests
@philippfromme
feat(client): increase test coverage
b296cce
@nikku
chore(client): throttle/debounce expensive UI updates
1a1a248 
* throttle drag events on #requestAnimationFrame for maximum 🍰
* debounce actual component updates
* put throttling/debouncing behavior into single place

Related to #1093
@nikku
chore(dragger): prevent jumping
2de5023 
* ignore wrong initial drag coordinate
* reformat code
feat(sync-fork): add mock modelers to set of unrelated files
b18805c
fix(karma): remove unrelated files
3f310c1
chore(project): synchronize with base modeler
ea47a0b
test(custom/PropertiesProvider): add test coverage
01dc6e7 
* rename directory
* add test coverage for properties provider
@dominikhorn93 dominikhorn93 merged commit d403822 into zeebe-io:master Jan 15, 2019
@nikku nikku mentioned this pull request Jan 16, 2019
Closed
@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Jan 16, 2019 •
edited
Loading

Hi @dominikhrn
The pull request was intended as Work in progress, since there were a couple of changes to be made before it would be ready to merge (ci, pending camunda-modeler release).

However it's fine that you merged it, so we can work fast-forward with new pull request incoming 🙂 If you have any questions/ recommendations regarding the new modeler's architecture and with the changes we made inside this pull request, always feel free to contact us 👍 Looking forward to some great work together!

@pinussilvestrus pinussilvestrus mentioned this pull request Jan 16, 2019
Merged
@dominikhorn93
Copy link
Contributor

Hi @pinussilvestrus
Sorry for that.
I checked it yesterday evening and everything worked like a charm.
If that's a problem we could do a rollback?

Currently I have no questions. You are doing a great job updating the modeler! 👍
If I can support you with something, feel free to contact me.

@pinussilvestrus
Copy link
Contributor Author

No problem, we will add further enhancements via pull requests 👍

@nikku nikku mentioned this pull request Jan 16, 2019
Closed
3 tasks
This was referenced Jan 22, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pinussilvestrus @dominikhorn93 @nikku @philippfromme @barmac