Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blade: Update to e142a3a to fix crash #17510

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

apricotbucket28
Copy link
Contributor

@apricotbucket28 apricotbucket28 commented Sep 6, 2024

Closes #17005

Like #17319, but based on kvark/blade#144.

This should be cherry-picked into preview if possible 🙂

Release Notes:

  • Linux: Fixed crash when closing windows on Wayland.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 6, 2024
@zed-industries-bot
Copy link

Messages
📖

This PR includes links to the following GitHub Issues: #17005
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against e50f84b

@jvmncs
Copy link
Contributor

jvmncs commented Sep 6, 2024

hm, these blade revisions not being on its main are breaking the flake builds at nix/build.nix. that's more due to an idiosyncrasy of crane (nix project used there) rather than anything in this work.

I've been meaning to figure out a fix for that, but any idea when these revisions will land on blade main?

@apricotbucket28
Copy link
Contributor Author

hm, these blade revisions not being on its main are breaking the flake builds at nix/build.nix. that's more due to an idiosyncrasy of crane (nix project used there) rather than anything in this work.

I've been meaning to figure out a fix for that, but any idea when these revisions will land on blade main?

Hmm, the master/preview branches are currently running this revision of Blade to fix some issues on Intel + Nvidia systems. According to #17022 (comment) it seems to be working fine so far, so hopefully it won't be long until those changes are merged.

@jvmncs
Copy link
Contributor

jvmncs commented Sep 6, 2024

yeah, I believe the nix builds broke for commits after #17022. luckily I don't think many people besides me use the flake build for themselves yet, just the devShell, which is unaffected. thanks!

@jvmncs jvmncs merged commit f91bf7f into zed-industries:main Sep 6, 2024
10 checks passed
@apricotbucket28 apricotbucket28 deleted the wayland-vulkan-crash branch September 6, 2024 20:00
notpeter pushed a commit that referenced this pull request Sep 6, 2024
Closes #17005

Like #17319, but based on
kvark/blade#144.

This should be cherry-picked into preview if possible 🙂 

Release Notes:

- Linux: Fixed crash when closing windows on Wayland.
@notpeter
Copy link
Member

notpeter commented Sep 6, 2024

I've kicked off the preview build and will publish the release (v0.152.2-pre) when it finishes.
Thanks @apricotbucket28

@potchin
Copy link

potchin commented Sep 9, 2024

Any idea when this is likely to hit the preview channel?

@notpeter
Copy link
Member

notpeter commented Sep 9, 2024

Our Linux Arm Github Actions runner was deprecated (running Ubuntu 20.04 to get an old LibC) and is no longer available. This prevented the release from finalizing. We may have to manually build for Linux on arm for a while until we get it going again with a newer runner. Fix here:

Apologies for the delay. We have been distracted by travel and prep for RustConf.

@notpeter
Copy link
Member

This is now out in Zed Preview v0.152.3.

@potchin
Copy link

potchin commented Sep 10, 2024

Prefect, confirmed fixed for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing a window crashes other Zed windows
5 participants