-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: output read orientation fractions to json #169
Conversation
…_orientation_json
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1142 1164 +22
=========================================
+ Hits 1142 1164 +22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues. In addition to the ones mentioned in line, I'm wondering if there aren't some docs that need to be updated? Example outputs maybe?
No docs update needed right now. I'll rewrite the full documentation on RtD, there it will be included. |
Oh, never mind. Had only a brief look and thought that you'd ended up including the stats in the main output after all. But seeing now that you're just writing it into a separate file, as discussed 👍 |
Description
Type of change
Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes
If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.