Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add processed sample paths to mapping #150

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: add processed sample paths to mapping #150

merged 2 commits into from
Nov 16, 2023

Conversation

balajtimate
Copy link
Collaborator

Description

Add the paths to the processed subset of samples to the mapping function in get_library_type.py, so that STAR makes use of them instead of the original (unprocessed) samples, when aligning to determinate the mate relationship.

Fixes #149

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

@balajtimate balajtimate changed the title feat: add processed sample paths to mapping fix: add processed sample paths to mapping Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8443c05) 100.00% compared to head (4c33968) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1108      1109    +1     
=========================================
+ Hits          1108      1109    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balajtimate balajtimate requested a review from uniqueg November 15, 2023 16:38
@uniqueg
Copy link
Member

uniqueg commented Nov 16, 2023

Hmm, coverage test is failing. Maybe you need to update the unit tests (or add one)?

Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the unit tests

@balajtimate
Copy link
Collaborator Author

I'm not sure why, the detailed coverage run says 100% (also for the PR). Can it be rerun?

@uniqueg
Copy link
Member

uniqueg commented Nov 16, 2023

Really weird. And no, I don't know how to rerun it without rerunning all the tests. Well, I think I'll just merge it then. If it persists, we can still investigate

@uniqueg uniqueg closed this Nov 16, 2023
@uniqueg uniqueg reopened this Nov 16, 2023
@uniqueg uniqueg merged commit 62fbf72 into dev Nov 16, 2023
27 of 29 checks passed
@uniqueg uniqueg deleted the add_map_paths branch November 16, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: STAR using uncompressed sample files when mate relationship is not
2 participants