Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from zarr3 config serialization #685

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 9, 2025

Removes the "id" attribute from the serialization when used as zarr3 codec, because it is redundant.
Before

{"name": "numcodecs.zfpy", "configuration": {"id": "zfpy", "mode": 3, "precision": 20}}

After:

{"name": "numcodecs.zfpy", "configuration": {"mode": 3, "precision": 20}}

See https://ossci.zulipchat.com/#narrow/channel/423692-Zarr/topic/using.20numcodecs.20codecs.20with.20zarr_format.3D3/near/492599440

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@normanrz normanrz self-assigned this Jan 9, 2025
@normanrz normanrz requested a review from dstansby January 9, 2025 09:09
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5502dc8) to head (0236ca3).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #685      +/-   ##
===========================================
+ Coverage   99.81%   100.00%   +0.18%     
===========================================
  Files          62        62              
  Lines        2752      2751       -1     
===========================================
+ Hits         2747      2751       +4     
+ Misses          5         0       -5     
Files with missing lines Coverage Δ
numcodecs/json.py 100.00% <ø> (+3.92%) ⬆️
numcodecs/tests/test_zarr3.py 100.00% <100.00%> (+3.12%) ⬆️
numcodecs/zarr3.py 100.00% <100.00%> (ø)

LDeakin added a commit to LDeakin/zarrs that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant