-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml - zfpy Versioning #671
Conversation
Zfpy release 1.0.1 which supports numpy > 2.0.
you may need to change/remove version check as well Lines 13 to 26 in 4b95d66
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 62 62
Lines 2747 2747
=======================================
Hits 2745 2745
Misses 2 2
|
@dstansby Please merge it if it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think it's worth keeping the warning if zfpy < 1.0.0
(which needs fixing, see my inline comment), but updating the dependencies in pyproject.toml is 👍
Zfpy release 1.0.1 which supports numpy > 2.0.
[Description of PR]
TODO: