Bump Ruff version and add formatting #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
TomNicholas
approved these changes
May 6, 2024
TomNicholas
reviewed
May 6, 2024
virtualizarr/xarray.py
Outdated
Comment on lines
2
to
11
| from typing import ( | ||
| List, | ||
| Literal, | ||
| Mapping, | ||
| Optional, | ||
| Union, | ||
| overload, | ||
| MutableMapping, | ||
| Iterable, | ||
| ) |
There was a problem hiding this comment.
I think we're still not using isort, otherwise these would be in alphabetical order.
There was a problem hiding this comment.
2c72571 looks promising. Is this what you would like? There are also options to do this case sensitive?
There was a problem hiding this comment.
Just if anyone is curious. All I did was add the "I" class as active to the linter: 8c128b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some config options to
pyproject.tomlto make the linting more closely resemble black. Happy to change/revert those.