Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning when passing indexes=None #357

Merged
merged 17 commits into from
Dec 18, 2024
Merged

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Dec 18, 2024

I think the warning being thrown here was really a misguided attempt to ensure that variables in the virtual dataset aren't too large. But generally it's much simpler to just create indexes for loadable variables instead, and not throw a warning.

@TomNicholas TomNicholas added the documentation Improvements or additions to documentation label Dec 18, 2024
@TomNicholas TomNicholas merged commit 3188ca0 into main Dec 18, 2024
11 checks passed
@TomNicholas TomNicholas deleted the remove_warning_indexes_None branch December 18, 2024 02:35
@TomNicholas TomNicholas mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inferring concatenation order from coordinate data values
1 participant