Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translators.kerchunk in preparation for TIFF reader fix #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elyall
Copy link

@elyall elyall commented Nov 14, 2024

  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

Two small changes:

  1. virtual_vars_from_kerchunk_refs now takes in arr_refs instead of refs. This allows a single array to be wrapped.
  2. find_groups is spun out. TIFFs can store a Dataset or a DataArray. So I was imagining this could be used for something like:
refs = kerchunk.tiff_to_zarr(urlpath)
is_dataarray = find_groups({"refs": refs}) == []

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (5e66ad0) to head (05b4c41).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   80.16%   81.86%   +1.69%     
==========================================
  Files          41       41              
  Lines        2516     2553      +37     
==========================================
+ Hits         2017     2090      +73     
+ Misses        499      463      -36     
Flag Coverage Δ
unittests 81.86% <100.00%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant