-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store test datasets in repo #235
base: main
Are you sure you want to change the base?
Conversation
This test
|
Great idea! We could make the file even smaller by down sampling spatially presumably. The failure shows that the variable is not being inlined when it previously was being inlined. This makes sense - which variables are inclined in the test is set by kerchunk's |
Thanks! Although, I can't take credit for the idea haha. Late night head scratcher, I can't seem to find the right
|
mypy errors seem to be unrelated: #249 |
Looking at this again, I think storing the datasets as file is great for roundtrip tests, but we should also strive to make other tests start from a point that doesn't require reading netCDF (and hence doesn't rely on kerchunk). That could either be in-memory kerchunk references, or on-disk kerchunk references that we then intepret using #251, or maybe it could even be something simpler in some cases. |
Adds a way to build test netcdf files and store them within the repo.
docs/releases.rst