Chunk-aligned indexing #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
commented
Jul 11, 2024
Comment on lines
+344
to
+347
| marr = create_manifestarray(shape=(4,), chunks=(2,)) | ||
| marr[0:2] | ||
| marr[2:4] | ||
| marr[0:4] |
There was a problem hiding this comment.
Need to come back and improve these placeholder tests
TomNicholas
commented
Jul 11, 2024
Comment on lines
+329
to
+332
| if chunk_length == 1: | ||
| # alot of indexing is possible only in this case, because this is basically just a normal array along that axis | ||
| chunk_slice = array_slice | ||
| return chunk_slice |
There was a problem hiding this comment.
Kind of interesting to realise this. You can even do things like slice(None, None, -1) to reverse the array in this case.
TomNicholas
commented
Jul 11, 2024
Comment on lines
+318
to
+324
| def _array_slice_to_chunk_slice( | ||
| array_slice: slice, | ||
| arr_length: int, | ||
| chunk_length: int, | ||
| ) -> slice: | ||
| """ | ||
| Translate a slice into an array into a corresponding slice into the underlying chunk grid. |
TomNicholas
commented
Jul 11, 2024
|
|
||
| indexer = _possibly_expand_trailing_ellipsis(key, self.ndim) | ||
| # _validate_indexer(indexer) |
There was a problem hiding this comment.
(probably don't need this as separate function)
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to subset
ManifestArrayobjects, as long as your indexer slice aligns with chunk boundaries.docs/releases.rstapi.rst