Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires-python = ">=3.10" #127

Merged
merged 1 commit into from
May 28, 2024
Merged

requires-python = ">=3.10" #127

merged 1 commit into from
May 28, 2024

Conversation

abarciauskas-bgse
Copy link
Collaborator

Fix for an error that arises when using python3.9:

Python 3.9.19 (main, Mar 19 2024, 16:08:27) 
[Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from virtualizarr import open_virtual_dataset

Traceback (most recent call last):
...
  File "/github/developmentseed/VirtualiZarr/virtualizarr/manifests/manifest.py", line 36, in ChunkEntry
    def from_kerchunk(cls, path_and_byte_range_info: list[str | int]) -> "ChunkEntry":
TypeError: unsupported operand type(s) for |: 'type' and 'type'

as I believe the type union operator was only implemented in 3.10: https://docs.python.org/3/whatsnew/3.10.html#pep-604-new-type-union-operator

@TomNicholas
Copy link
Member

Do you particularly need 3.9? Julia removed support for it in #112 for this exact reason.

(Also clearly we need to release this package so we're not all just using main - I'm trying to push that in https://github.com/orgs/zarr-developers/discussions/70#discussioncomment-9577781)

@abarciauskas-bgse
Copy link
Collaborator Author

@TomNicholas I don't need 3.9 at all, I just happened to notice that the package wasn't working in 3.9 as that was my default python3 version.

@TomNicholas
Copy link
Member

Sorry I misread what this PR does - I see now this is just something that should have been added in Julia's PR!

Thanks @abarciauskas-bgse !

@TomNicholas TomNicholas merged commit 77ac8c7 into main May 28, 2024
5 checks passed
@TomNicholas TomNicholas deleted the ab/require-python-3.10 branch June 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants