Skip to content

Commit

Permalink
dmrpp root and nested group parsing fix (#265)
Browse files Browse the repository at this point in the history
* add root group and nested group support

* refactor functions for readability

* upgrade test suite

* resolve conflicts

* fix mypy types

* update dmrpp default fill_val

* update dmrpp default datapath

* add dedent() to pytest fixtures

* update function docs and releases

---------

Co-authored-by: Tom Nicholas <[email protected]>
  • Loading branch information
ayushnag and TomNicholas authored Nov 8, 2024
1 parent 4ae7a19 commit 9e7d430
Show file tree
Hide file tree
Showing 4 changed files with 511 additions and 355 deletions.
2 changes: 2 additions & 0 deletions docs/releases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Deprecations
Bug fixes
~~~~~~~~~

- Handle root and nested groups with ``dmrpp`` backend (:pull:`265`)
By `Ayush Nag <https://github.com/ayushnag>`_.
- Fixed bug with writing of `dimension_names` into zarr metadata.
(:pull:`286`) By `Tom Nicholas <https://github.com/TomNicholas>`_.
- Fixed bug causing CF-compliant variables not to be identified as coordinates (:pull:`191`)
Expand Down
4 changes: 2 additions & 2 deletions virtualizarr/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ def open_virtual_dataset(
File path to open as a set of virtualized zarr arrays.
filetype : FileType, default None
Type of file to be opened. Used to determine which kerchunk file format backend to use.
Can be one of {'netCDF3', 'netCDF4', 'HDF', 'TIFF', 'GRIB', 'FITS', 'zarr_v3', 'kerchunk'}.
Can be one of {'netCDF3', 'netCDF4', 'HDF', 'TIFF', 'GRIB', 'FITS', 'dmrpp', 'zarr_v3', 'kerchunk'}.
If not provided will attempt to automatically infer the correct filetype from header bytes.
group : str, default is None
Path to the HDF5/netCDF4 group in the given file to open. Given as a str, supported by filetypes “netcdf4” and “hdf5”.
Path to the HDF5/netCDF4 group in the given file to open. Given as a str, supported by filetypes “netcdf4”, “hdf5”, and "dmrpp".
drop_variables: list[str], default is None
Variables in the file to drop before returning.
loadable_variables: list[str], default is None
Expand Down
Loading

0 comments on commit 9e7d430

Please sign in to comment.