Skip to content

Commit

Permalink
Clarify that passing indexes={} does work on xarray main, just concat…
Browse files Browse the repository at this point in the history
… doesn't
  • Loading branch information
TomNicholas authored May 3, 2024
1 parent 97da298 commit 3ba30c7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,6 @@ Indexes:
*empty*
```

```{note}
Passing `indexes={}` will only work if you use a [specific branch of xarray](https://github.com/pydata/xarray/pull/8872), as it requires an in-progress PR, see [GH issue #14](https://github.com/TomNicholas/VirtualiZarr/issues/14#issuecomment-2018369470).
```

As we know the correct order a priori, we can just combine along one dimension using `xarray.concat`.

```
Expand All @@ -232,6 +228,10 @@ Attributes:
title: 4x daily NMC reanalysis (1948)
```

```{note}
Concatenation without indexes like this will only work if you use a [specific branch of xarray](https://github.com/pydata/xarray/pull/8872), as it requires an in-progress PR, see [GH issue #14](https://github.com/TomNicholas/VirtualiZarr/issues/14#issuecomment-2018369470).
```

We can see that the resulting combined manifest has two chunks, as expected.

```python
Expand Down

0 comments on commit 3ba30c7

Please sign in to comment.