Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow/script to generate scan policies based on rule tags #5962

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Nov 29, 2024

Overview

  • generate-scan-policies.js > ZAP standalone script to be used by a nightly docker image to craft the scan policies.
  • generate_policies.yml > The new workflow. Triggered by cron every Friday morning or manually via workflow_dispatch.

Related Issues

#5930

Checklist

  • [na] Update help
  • [na] Update changelog
  • [na] Run ./gradlew spotlessApply for code formatting (I did format the script based on the community-script formatter)
  • [na] Write tests (Tested in another repo)
  • [na] Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin kingthorin force-pushed the scanpol-wf branch 2 times, most recently from 3d4f0a7 to 517d5c0 Compare November 29, 2024 11:23
@thc202 thc202 changed the title scanpolicies: Add workflow/script to generate updates based on rule tags Add workflow/script to generate scan policies based on rule tags Nov 29, 2024
@kingthorin kingthorin force-pushed the scanpol-wf branch 4 times, most recently from 5a1f92f to 7d7b587 Compare November 29, 2024 12:14
@psiinon

This comment was marked as resolved.

@kingthorin kingthorin force-pushed the scanpol-wf branch 2 times, most recently from c228432 to 069d64b Compare November 30, 2024 21:29
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/scripts/generate-scan-policies.js Outdated Show resolved Hide resolved
.github/workflows/generate_policies.yml Outdated Show resolved Hide resolved
.github/workflows/generate_policies.yml Outdated Show resolved Hide resolved
@kingthorin
Copy link
Member Author

Fixed

@kingthorin kingthorin force-pushed the scanpol-wf branch 2 times, most recently from 592bd4e to 4b67e49 Compare December 2, 2024 10:57
@kingthorin
Copy link
Member Author

Tweaked

@thc202
Copy link
Member

thc202 commented Dec 2, 2024

This one still pending #5962 (comment)

- generate-scan-policies.js > ZAP standalone script to be used by a
nightly docker image to craft the scan policies.
- generate_policies.yml > The new workflow. Triggered by cron every
Friday morning or manually via workflow_dispatch.

Signed-off-by: kingthorin <[email protected]>
@kingthorin
Copy link
Member Author

Done

@thc202
Copy link
Member

thc202 commented Dec 2, 2024

Thank you!

@thc202 thc202 merged commit 5b0be3b into zaproxy:main Dec 2, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@kingthorin kingthorin deleted the scanpol-wf branch December 2, 2024 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants