Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ory Kratos authentication scripts #447

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

getlarge
Copy link
Contributor

@getlarge getlarge commented May 31, 2024

Description

I added two authentication scripts to enable authenticated interactions with web applications relying on Ory Kratos.

I hope they may be useful for others in the Zap community.

@thc202
Copy link
Member

thc202 commented May 31, 2024

The commits need to be signed-off: https://github.com/zaproxy/community-scripts/pull/447/checks?check_run_id=25640107047
You need to run the spotlessApply task (e.g. ./gradlew sA) to fix the formatting of the scripts.
The changelog should be updated to mention the new scripts: https://github.com/zaproxy/community-scripts/blob/main/CONTRIBUTING.md#changelog

@getlarge getlarge force-pushed the feat-add-kratos-authentication-scripts branch from 095a81d to 147a647 Compare May 31, 2024 08:53
@getlarge
Copy link
Contributor Author

The commits need to be signed-off: https://github.com/zaproxy/community-scripts/pull/447/checks?check_run_id=25640107047 You need to run the spotlessApply task (e.g. ./gradlew sA) to fix the formatting of the scripts. The changelog should be updated to mention the new scripts: https://github.com/zaproxy/community-scripts/blob/main/CONTRIBUTING.md#changelog

Sorry, I missed the contribution guidelines. Too bad I had to remove my GPG signature ;)
Should be good now!

@getlarge getlarge force-pushed the feat-add-kratos-authentication-scripts branch from 27d0d5f to 07b1895 Compare May 31, 2024 09:09
@thc202
Copy link
Member

thc202 commented May 31, 2024

You can still sign the commits.

@getlarge
Copy link
Contributor Author

Yes, but not during the rebase unfortunately.

@getlarge
Copy link
Contributor Author

@thc202 Can you help for the reviewing of this PR? Is anything blocking?

authentication/KratosApiAuthentication.js Outdated Show resolved Hide resolved
authentication/KratosApiAuthentication.js Outdated Show resolved Hide resolved
authentication/KratosApiAuthentication.js Outdated Show resolved Hide resolved
getlarge added 2 commits June 13, 2024 15:22
Signed-off-by: Edouard Maleix <[email protected]>
Signed-off-by: Edouard Maleix <[email protected]>
@getlarge
Copy link
Contributor Author

@thc202 Just applied your suggestions.

@thc202 thc202 enabled auto-merge (squash) June 13, 2024 13:59
@thc202
Copy link
Member

thc202 commented Jun 13, 2024

Thank you!

@thc202 thc202 merged commit a5c4259 into zaproxy:main Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants