Type-safe package scan for ConfigurationServiceScan #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukasniemeier-zalando
commented
Dec 4, 2023
lukasniemeier-zalando
commented
- add type-safe alternative for the "basePackage" attributes of ConfigurationServiceScan
- add tests covering all three scanning attributes
* add type-safe alternative for the "basePackage" attributes of ConfigurationServiceScan * add tests covering all three scanning attributes
|
Could you elaborate in the PR description what motivates this change? |
|
It's the type-safe alternative to Right now library users have to provide a String value which hopefully points to an actual package: besides typos on the initial setup, we have also seen refactorings, which missed out on changing the non-type-safe |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.