[chore] Apply formatting #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eomiso
force-pushed
the
aesop/chore-apply-formatting
branch
from
5587da5
to
96330fc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
포매팅과 상관 없는 코드가 포함된게 있어서 (ItemRequestTest.php) 지우고 다시 force push 했습니다. 다음 PR 에 포함될 예정입니다. |
eomiso
added a commit
that referenced
this pull request
Aug 18, 2023
* chore: Apply formatting (#5) * chore: Apply formatting to files that was obmitted * feat: Refactor project file tree * [feat] Add send request method and items Request class (#10) * test: Add test code for Single ItemAdd * feat: Add uuid generator to test-utils * test: Add failing Request class test * test: Add failing test for ItemRequest class * feat: Add ItemRequest and Item class * chore: Remove unecessary comment [Why] SVC 에서 알아서 누가 어느줄을 작성했는지 보여주기 때문에 (git blame) 불필요한 boilerplate임 * test: Add default items payload generator Added a utility function to TestUtils * test: Add failing test for AddItemTest * feat: Add AddItem class * test: Add failing test for Zaiclient sendRequest * chore: Change snake cased method names * test: Add failing test for sendRequest method * feat: Add sendRequest method to ZaiClient * [feat] Add UpdateItem, DeleteItem and Events (#11) * test: Add failing test for delete and update item * test: Add validation testing in AddItemTest * feat: Add UpdateItem and DeleteItem class Validation to the constructor of these classes is not necessary. It is done when creating the Item class for the request payload. * refac: Remove call_type header The Collector API no longer needs this header. * test: Add failing test for Event Request * feat: Add EventRequest Class * test: Add failing test for Event Request * feat: Add Event class * feat: Implement EventRequest further to pass tests Previously there were tests that didn't pass. Because it wasn't able to get the payloads * [feat] Add all events, recommendation request with test codes (#12) * refac: Add more error logs to validation * test: Add failing test for Recommendation * feat: Add isAssoc function to utility function * feat: Add Recommendation Request * feat: Add GetUserRecommendation * feat: Add GetRelatedRecommendation, GetRerankingRecommendation * refac: Create a folder tree for Request tests * feat: Add ProductDetailView Request class * feat: Add PurchaseEvent class * refac: Rename isAssoc fn to isAssociativeArray * feat: Add AddpurchaseEvent class * feat: Add AddRateEvent class * feat: Add Other Event classes * feat: Fix errors due to change in Validator * fix: Fix error when setting time_to_live * [feat] Fix minor errors (#13) * fix: Fix minor errors * feat: Add integration test and reorder file tree * fix: Add Item mapper * fix: Fix error in item requests * fix: Delete all unecessary files * chore: Add phpunit.xml * refac: Rename isZaiRec param for PageViewEvent * chore: Fix the sonarlint errors * refac: Change EventResponse class name to EventLoggerResponse * feat: Fix minor typos and unecessary variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0 Update 1st PR
Reference
What has changed
본격적인 작업에 앞서 포매팅 + 린팅을 설정했습니다.
editorconfig(모든 언어에 대해서 기본적인 포매팅 설정 가능 - 주로 여러 언어가 함께 사용될 때 사용) DEVSENSE에서 나온 PHPtool 이라는 extension을 이용해 설정했습니다. 앞으로 다른 언어로 된 레포들에도 이런식으로 .vscode 세팅을 넣어 두려고 해요.vscode에서만 제공되는 툴로 포매팅 및 린팅을 하는건 좋은 practice는 아닙니다. 하지만 PHP는 이 레포 외에는 사용할 일이 없는 언어라서 가장 빨리, 손이 덜가는 방향으로 세팅했습니다.
다른 프로젝트들 같은 경우에는 .editorconfig + .blackrc + .ruffrc, 또는 .editorconfig + pyproject.toml 을 이용해서 설정해줄 예정이에요(ts같은 경우는 .editorconfig + .prettierrc + .eslintrc 가 되겠죠?). 그래야 IDE에 독립적으로 Language Server에 설정이 먹히거든요.
What to look for
소스코드에는 포매팅만 적용되었어야 하는데 작업하다가 혹시 다른 코드가 섞여들어간 건 없는지 (시간 없으시면 패스하셔도 됩니다. 미리 작업 싱크 하는 수준의 PR이라서요)
.vscode랑 .editorconfig 만 간단하게 봐주시면 되겠습니다ㅎㅎ