Support dbt-core 1.9 #186
Merged
Support dbt-core 1.9 #186
+1,843
−1,549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syou6162
force-pushed
the
support_dbt_1.9.0
branch
from
bb906b2 to
d6ae2ad
Compare
syou6162
force-pushed
the
support_dbt_1.9.0
branch
from
d6ae2ad to
8854c47
Compare
syou6162
commented
Dec 10, 2024
syou6162
commented
Dec 10, 2024
|
@z3z1ma Could you review this pull request? The pull request fixes also include dropping support for older versions of dbt, so I would also like to have the policy reviewed for appropriateness. |
Closed
|
LGTM. Will go through things again before cutting a pypi release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, dbt 1.9.0 has been released 🎉. Since dbt-osmosis only supported up to 1.8, I made the necessary changes to dbt 1.9 in this pull request.
When dbt-core was upgraded to 1.9, I discovered that CI for versions of dbt prior to 1.7 would fail due to the change in the protobuf version requirement to
>=5.0,<=6.0(note that the dbt-osmosis test is not failing, but thedbt parsepart is failing).It is possible to add support for protobuf if you put in a lot of effort, but since dbt versions prior to 1.7 are reaching their end of life, I thought it would be difficult to continue supporting them.
Also, since the dbt-osmosis artifacts are managed by version, users who want to use versions prior to dbt 1.7 can continue to use them by specifying a specific release version. For this reason, I have excluded dbt 1.6 and 1.7 from the scope of support in this pull request.