Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move chroma into functions #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

amezin
Copy link

@amezin amezin commented Apr 12, 2024

Pull request template

Type of changes

  • CI
  • Bugfix
  • Feature
  • Generic maintenance tasks
  • Documentation content changes
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no URL changes)
  • Improving the performance of the project (not introducing new features)
  • Other (please describe):

Issue Number: #41

What is the current behavior?

Command-specific highlighting does not work.

$ chroma/-git.ch
zsh: chroma/-git.ch: function definition file not found

What is the new behavior?

Command-specific highlighting works, chroma/*.ch load successfully.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

Make chroma functions load.

Otherwise `chroma` isn't in `fpath`:

    zsh: chroma/-git.ch: function definition file not found

Fixes z-shell#41
@ss-o ss-o added the triage 📑 The issue is awaiting investigation. label Apr 12, 2024
@ss-o
Copy link
Member

ss-o commented Apr 12, 2024

Hi @amezin 👋

Could you provide instructions on how to reproduce your issue?

@amezin
Copy link
Author

amezin commented Apr 12, 2024

Just use the plugin without any package/plugin manager. https://github.com/z-shell/F-Sy-H/blob/main/docs/README.md#manual

Git subcommands (i.e. "checkout" in "git checkout") won't be highlighted. Zsh will fail to load any chroma/*.ch. Because only functions directory will be added to fpath, not the root directory.

@setpill
Copy link

setpill commented Aug 7, 2024

Also experiencing this bug when loading F-Sy-H via zplug. Can confirm that switching to amezin/F-Sy-H@fix/chroma solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage 📑 The issue is awaiting investigation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants