[ISSUE apache#8372] Add more test coverage for AdminBrokerProcessor

yx9o · Jul 17, 2024 · 2d1e314 · 2d1e314
1 parent 1588d65
commit 2d1e314
Show file tree

Hide file tree

Showing 2 changed files with 454 additions and 19 deletions.
diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
@@ -1941,7 +1941,7 @@ private RemotingCommand getAllMessageRequestMode(ChannelHandlerContext ctx, Remo
         final RemotingCommand response = RemotingCommand.createResponseCommand(null);
 
         String content = this.brokerController.getQueryAssignmentProcessor().getMessageRequestModeManager().encode();
-        if (content != null && content.length() > 0) {
+        if (content != null && !content.isEmpty()) {
             try {
                 response.setBody(content.getBytes(MixAll.DEFAULT_CHARSET));
             } catch (UnsupportedEncodingException e) {