Unify the implementation of builder for path and that for stroke and fill #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69
The current implementation flatten curves in a different way for path:
StrokeOptions
andFillOptions
).CubicBezierSegment
orQuadraticBezierSegment
on the fly and flatten it.It seems the latter way produces different results than the first one (probably the order of scaling operations might matter...?). This pull request changes this by making flattening happen in the Builder. This requires a bit tricky setup.
PathBuilder
because the tesselator flattens laterPathBuilder
Before:
After: