-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: make pyproject.toml
the one source of truth for test-only dependencies
#532
Open
neutrinoceros
wants to merge
6
commits into
yt-project:main
Choose a base branch
from
neutrinoceros:dep/pep735_test_deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
dep/pep735_test_deps
branch
2 times, most recently
from
October 29, 2024 11:14
8ee31ff
to
b1745fc
Compare
Apparently something I did broke tox env selection in CI so every job runs every env. I don't know yet if that's the reason it's failing, or if that's a different problem. |
neutrinoceros
force-pushed
the
dep/pep735_test_deps
branch
2 times, most recently
from
October 29, 2024 12:05
a7ab028
to
45c2d57
Compare
neutrinoceros
changed the title
DEP: make pyproject.toml the one source of truth for test-only dependencies"
DEP: make Oct 29, 2024
pyproject.toml
the one source of truth for test-only dependencies
I resolved the problem mentioned above by using |
….toml (PEP 735 dependency groups)
neutrinoceros
force-pushed
the
dep/pep735_test_deps
branch
from
October 29, 2024 12:12
45c2d57
to
6f1d19f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
One source of truth
Dependency groups
Move dev-only dependency specifications from
tox.ini
topyproject.toml
as PEP 735 Dependency Groups.The PEP was accepted a couple weeks ago and is already supported by tox as well as uv, which allow running tests without tox as, for instance
uv run --group test pytest
Rely on
uv
's dependency resolver to test with pinned versionsAvoid duplication of metadata for oldest supported versions of our dependencies by switching dependency resolution strategy. This is supported by
uv
(viatox-uv
).Notes:
Drop pytest-cov
I removed
pytest-cov
from our testing pipeline, as it's a completely unnecessary layer of indirection betweenpytest
andcoverage
. I switched to direct invokes tocoverage
.While I was at it, I also re-organized
tox.ini
a bit (mostly moving lines around).