Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 5 support (without Python 3.12) #283

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

pfouque
Copy link

@pfouque pfouque commented Oct 30, 2023

Just adding last version of Django to the test matrix and package classifier

The test results are available on my repository: pfouque#1

Reworked to split with #284 (depending on the first to merge we will have to adapt)
(We will have to update the Django 5 version number anyway as soon it's officially released)

@pfouque pfouque marked this pull request as draft October 30, 2023 07:44
@pfouque pfouque marked this pull request as ready for review October 30, 2023 07:48
@pfouque pfouque marked this pull request as draft October 30, 2023 08:46
@marianoeramirez
Copy link
Collaborator

Its hard that this work. Because we need to upgrade some dependents librarys like django-dbdiff or get rid of it.

@pfouque
Copy link
Author

pfouque commented Oct 31, 2023

Thanks for the tip @marianoeramirez, It will take time a bit more time to investigate if the best way is to find an alternative test method or update django-dbdiff (it has only one usage of the imp module but has not been updated in a while...)

@pfouque
Copy link
Author

pfouque commented Nov 6, 2023

Depends on yourlabs/django-dbdiff#21

Copy link

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some minor comments.

.github/workflows/django.yml Outdated Show resolved Hide resolved
CHANGELOG Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
Copy link
Author

@pfouque pfouque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I temporarily added yourlabs/django-dbdiff#21 as the source dependency and it looks fine!
https://github.com/pfouque/django-cities-light/actions/runs/6835469902

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95d2af7) 91.24% compared to head (2646674) 91.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          44       44           
  Lines        1794     1794           
=======================================
  Hits         1637     1637           
  Misses        157      157           

@pfouque pfouque marked this pull request as ready for review November 11, 2023 20:33
@pfouque pfouque mentioned this pull request Nov 23, 2023
@pfouque pfouque changed the title Add Django 5 & Python 3.12 support Add Django 5 support (without Python 3.12) Nov 23, 2023
tox.ini Outdated Show resolved Hide resolved
@marianoeramirez
Copy link
Collaborator

@pfouque can you update your base branch with last commits?

@marianoeramirez marianoeramirez merged commit e45d984 into yourlabs:master Jan 9, 2024
7 checks passed
@pfouque pfouque deleted the dj5 branch January 9, 2024 11:57
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants