-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 5 support (without Python 3.12) #283
Conversation
Its hard that this work. Because we need to upgrade some dependents librarys like django-dbdiff or get rid of it. |
Thanks for the tip @marianoeramirez, It will take time a bit more time to investigate if the best way is to find an alternative test method or update |
Depends on yourlabs/django-dbdiff#21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I temporarily added yourlabs/django-dbdiff#21 as the source dependency and it looks fine!
https://github.com/pfouque/django-cities-light/actions/runs/6835469902
@pfouque can you update your base branch with last commits? |
"Programming Language :: Python", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
Just adding last version of Django to the test matrix and package classifier
The test results are available on my repository: pfouque#1
Reworked to split with #284 (depending on the first to merge we will have to adapt)
(We will have to update the Django 5 version number anyway as soon it's officially released)