Cgroup v1 pid integration tests

[Furisto]

• Implements the cgroup v1 pid tests
• Added more context to error messages and added a new function for checking if the container was created successfully
• I realize this is subjective but I found Passed, Skipped and Failed more understandable for TestResult so I changed the names. I can change it back if you prefer the older names.
• I think we should have a convention for the used cgroups path. I set it as [cgroup_root]/runtime-test/[test_name]
• The spec does not state what should happen if the limit is zero or negative, but we and runc just set unlimited in this case. We should write down where the spec is ambiguous, so that we do not forget it. This can then be used to improve the spec. For now I just added //SPEC in front of such comments in the code. Other suggestions welcome.

#361

[codecov-commenter]

Codecov Report

Merging #391 (04a8fa8) into main (66c2eab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files          52       52           
  Lines        8280     8280           
=======================================
  Hits         6370     6370           
  Misses       1910     1910           

[YJDoc2]

Hey, I will take a good detailed look once again tomorrow, but some things that I noticed :

• context messages and helper function is an excellent addition! Thank you for adding that !
• Our TestResult enum was meant to follow after Rust's Result, with adding a Skip variant, so I kept names of others same as Result. I do understand that Passed, Skipped and Failed make more sense, but I also feel a bit that if we are using Result in the name, we should keep the variant names similar 😅 I'll think more on this...
• Using a common convention for cgroup path is good, but the created cgroup is not removed once the test are over (runtime-test directory remains after tests are over). We can manually remove this with remove_dir, after all container processes are exited, but then we should add the clean up function. I don't feel leaving an extra cgroup directory (even if it doesn't give issues) on tester's system is a good thing.

[Furisto]

@YJDoc2 PTAL

[YJDoc2]

Hey @Furisto , so I think let the enum names be Passed,Skipped and Failed(e) ; in case we run into an issue with them, we can see later.
Please check this from my last comment :

Using a common convention for cgroup path is good, but the created cgroup is not removed once the test are over (runtime-test directory remains after tests are over). We can manually remove this with remove_dir, after all container processes are exited, but then we should add the clean up function. I don't feel leaving an extra cgroup directory (even if it doesn't give issues) on tester's system is a good thing.

And also can you mention the macro in readme of test_framework and the check_container_created function in the tests readme, under https://github.com/containers/youki/tree/main/youki_integration_test#utils-provided ?

Other than that I think the code looks good 👍

[Furisto]

@YJDoc2 Done

[YJDoc2]

LGTM 👍
Thank you!