Add a relative_network_cgroups test as one of the integration tests #2986
+102
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moz-sec <[email protected]>
moz-sec
force-pushed
the
add-test-relative-network
branch
from
4696ba0
to
b332eb0
Compare
moz-sec
changed the title
|
Hey, thanks for the PR :) |
YJDoc2
reviewed
Nov 25, 2024
Comment on lines
62
to
65
| test_outside_container(spec, &|data| { | ||
| test_result!(check_container_created(&data)); | ||
| TestResult::Passed | ||
| }) |
There was a problem hiding this comment.
Hey, here along with checking if the container is created, we also need validation for the created network cgroup resources - In the original test we call this function which does the validation, so need that here as well.
There was a problem hiding this comment.
Thank you.
Added validation for the created network cgroup resources.
There was a problem hiding this comment.
Hey, I don't think it is fixed yet. Let me clarify in case there is any confusion -
- In the original go test, at line https://github.com/opencontainers/runtime-tools/blob/master/validation/linux_cgroups_relative_network/linux_cgroups_relative_network.go#L24C1-L24C77, in the
test_outside_container, they are passingutil.ValidateLinuxResourcesNetworkfunction, which will do the validation that ok, the runtime has actually setup the relative network correctly. - The
util.ValidateLinuxResourcesNetworkfunction defined at https://github.com/opencontainers/runtime-tools/blob/master/validation/util/linux_resources_network.go#L12 does the checking and validation of relative network cgroup. - The change you did in the last commit you pushed is actually almost a no-op. The original way of just calling the
test_outside_containerwas correct, but also needs the cgroup checking logic as mentioned above.
Signed-off-by: moz-sec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the relative_network_cgroups validation in #361 .
I wrote it based on linux_cgroups_relative_network.go from
opencontainers/runtime-toolsand tests/cgroups/network.rs fromyouki-dev/youki.