-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process test #2968
Add process test #2968
Conversation
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
I figure out why the test failed. I reproduced it on my PC.
But runc is, even if /test is not in rootfs, runc run is working.
If we add a test directory to the rootfs you use for testing, the tests will pass. Sorry, I don't understand the detailed code of runc or youki, but I think it looks like runc is creating the cwd directory in this line. What is the difference between the behavior of runc and youki? |
Hey, thanks for the ping, I'll try to take a look at this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, also there are several warnings from the CI check, please take a look
Hey @sat0ken , I took a look at the code and there are two things -
|
Also @sat0ken a small request, please ping/comment in the tracking issue before opening a e2e test PR, so we can properly keep track. I have added your current PRs, but please comment for future ones. Thanks! |
@YJDoc2 |
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Hey @sat0ken , There are some conflicts and I have left a comment above on the still failing tests, please take a look. |
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
@YJDoc2 Hi, thank you for comment and support. I fixed conflict and code. Could you please check? |
@YJDoc2 Ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nitpicks, but overall looks good.
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
@YJDoc2 Thank you for review and comments. I've fixed the code. Could you please check the code? |
Signed-off-by: Yashodhan Joshi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 Thanks
This implements the process validation in #361.