Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FE) Wrong Presence Information #96

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

devleejb
Copy link
Member

What this PR does / why we need it:

  • Add calling client.subscribe("others", ...) when observing presence
  • Add calling client.detach(doc) when exit page
  • Remove codemirror decorations when peers changed to unwatched

Which issue(s) this PR fixes:

Fixes #95

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@devleejb devleejb added the bug 🐞 Something isn't working label Jan 24, 2024
@devleejb devleejb self-assigned this Jan 24, 2024
@devleejb devleejb merged commit 6f1928a into main Jan 24, 2024
1 check passed
@devleejb devleejb deleted the 95-fe-wrong-presence-information branch January 24, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(FE) Wrong Presence Information
1 participant