bugfix for setColumn in LedControl.py

[IIIHeloIII]

setColumn is not working because the row iterator is called 'i' not 'row'.

[lexbailey]

Aha!
This came out of the blue. Thanks for pointing this out.
I don't think we're using this code at the moment (hence we hadn't spotted this bug).
I'm git-blamed for this file at the moment but only because of a mass-movement of code to a new repo.
This code was added by @RorschachUK so I'll let him decide what to do with this pull request.

Thanks again.
Dan.

[aquila12]

Is this the driver for the top-box LED matrices (the ones that are
currently still driven by the nanos embedded with them)?

On 17 October 2016 at 20:20, Daniel Bailey [email protected] wrote:

Aha!
This came out of the blue. Thanks for pointing this out.
I don't think we're using this code at the moment (hence we hadn't spotted
this bug).
I'm git-blamed for this file at the moment but only because of a
mass-movement of code to a new repo.
This code was added by @RorschachUK https://github.com/RorschachUK so
I'll let him decide what to do with this pull request.

Thanks again.
Dan.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF1XJsjDCTYN_1SVNnpGB5mKcf89o-L9ks5q08qZgaJpZM4KY_ac
.

[lexbailey]

@aquila12 Yes, I believe so. I think we had plans to drive them from the BBBs a long time ago but haven't got to that stage yet. I'd still like to do that some day, it would allow us to make them react to events that occur in the game. At the moment the arduinos know nothing about the game, they just loop a single animation constantly.

[IIIHeloIII]

I have no idea which topbox you are talking about, I just needed some python code to drive my dot matrix display using MicroPython running on my NodeMcu ESP8266 development board. The pins are accessed in a slightly different way but apart from that, the script works fine.

I found your script by searching for "LedControl.py" after watching an Arduino video on YouTube where they used Wayoda LedControl from Github (cpp version).

I was just too lazy to rewrite the cpp code to python myself :)

When I realized there was a bug in your script, I just thought I would let you know.