-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make esri url checks more general #40
Make esri url checks more general #40
Conversation
broaden scope of accceptable esriUrl_isValid urls so it doesn't always have to be and service endpoint add esriUrl_isValidRoot and esriUrl_isValidFolder still need to update and add new tests for this functionality
Rewrite esri url base
@elipousson Here is what I am pulling together to fix the esriUrl_isValid issues in #39 . I want to go a little deeper and make sure everything is still working correctly in some of the functions that don't have tests built for them yet. Main thing is a major update to generalize esriUrl_isValid, but I also made some slight changes in the output of esriUrl_parseUrl and changed a couple function names. The function names I changed I just did a simple wrapper around the original function with a deprecation warning. This will be what we use if we decide to change standardize function names in the package. Feel free to download the branch and play with it to see if it will work with your idea of the esriIndex function. |
…a URL in esriUrlValidType if an 'Invalid URL' message is returned by the server.
added token param to esriLayers included a private test
Purpose: Adapt esriUrl_isValid to accept valid, but non-service/feature URL's like the root of a server or a folder page like https://sampleserver1.arcgisonline.com/ArcGIS/rest/services/Demographics or https://sampleserver1.arcgisonline.com/ArcGIS/rest/services
Deprecated/Renamed Exported Functions:
Added Functions:
Changed Functions: