Minus vcpkg

.github/workflows/code_format.yml

@@ -5,8 +5,7 @@ jobs:
   cmake-format:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Format CMake files
         uses: PuneetMatharu/[email protected]
@@ -17,9 +16,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run clang-format style check for C/C++/Protobuf programs.
-        uses: jidicula/clang-format-action@v4.5.0
+        uses: jidicula/clang-format-action@v4.11.0
         with:
-          clang-format-version: '14'
+          clang-format-version: '17'

.github/workflows/coverage.yml

@@ -4,54 +4,55 @@ on: [push]
 jobs:
   coverage:
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+      contents: read
     steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: 'true'
+      - uses: actions/checkout@v4
 
       - name: Get latest cmake
         uses: lukka/get-cmake@latest
 
-      - name: set compiler
-        run: |
-          echo "CXX=g++-10" >> $GITHUB_ENV
-          echo "CC=gcc-10" >> $GITHUB_ENV
+      - name: Install gcovr
+        run: pip install gcovr
 
       - name: Configure
         env:
-          CXXFLAGS: --coverage -g -O0
-          CFLAGS: --coverage -g -O0
+          CXXFLAGS: --coverage -fprofile-abs-path -g -O1
+          CFLAGS: --coverage -fprofile-abs-path -g -O1
           LDFLAGS: --coverage
-        run: cmake --toolchain ../vcpkg/scripts/buildsystems/vcpkg.cmake -B build -S .
+          CC: gcc-13
+          CXX: g++-13 # gcov (!= gcovr) version should match
+        run: cmake -S . -B build -D VCPKG_TARGET_TRIPLET=x64-linux --toolchain "${VCPKG_INSTALLATION_ROOT}/scripts/buildsystems/vcpkg.cmake"
 
       - name: Build
         run: cmake --build build --parallel
 
       - name: Execute
-        run: cmake --build build --target test
-
-      - name: Install gcovr
-        run: |
-          sudo apt-get update
-          sudo apt-get install -yq gcovr
-          sudo apt-get clean
+        run: ctest --test-dir build
 
       - name: Create report
         run: |
-          mkdir html
-          gcovr --filter include/io1/money.hpp --exclude-unreachable-branches --exclude-lines-by-pattern '.*assert.*' --print-summary -x coverage.xml --html-details html/index.html --html-details-syntax-highlighting -r . build
-
-      - uses: 5monkeys/cobertura-action@v13
-        with:
-          path: coverage.xml
-          repo_token: ${{ secrets.GITHUB_TOKEN }}
-          minimum_coverage: 84
-          fail_below_threshold: true
-          show_line: true
-          show_branch: true
-          show_missing: true
+          mkdir build/html
+          gcovr --gcov-executable /usr/bin/gcov-13 --filter include/io1/money.hpp --exclude-unreachable-branches --exclude-lines-by-pattern '.*assert.*' --print-summary -x build/coverage.xml --html-details build/html/index.html --html-details-syntax-highlighting -r . build
 
       - uses: actions/upload-artifact@v3
         with:
           name: detailed coverage report
-          path: html
+          path: build/html
+
+      - uses: irongut/[email protected]
+        with:
+          filename: build/coverage.xml
+          badge: true
+          fail_below_min: true
+          format: markdown
+          output: both
+          thresholds: '75 90'
+
+      - name: Add Coverage PR Comment
+        uses: mshick/add-pr-comment@v2
+        with:
+          message-id: coverage
+          refresh-message-position: true
+          message-path: code-coverage-results.md

.github/workflows/unit_tests.yml

@@ -8,27 +8,50 @@ jobs:
       matrix:
         config: [Release, Debug]
         os: [ubuntu-latest, windows-latest]
+        compiler: [gcc, clang, msvc]
+        exclude:
+          - os: windows-latest
+            compiler: gcc
+          - os: windows-latest
+            compiler: clang
+          - os: ubuntu-latest
+            compiler: msvc
     steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: 'true'
+      - uses: actions/checkout@v4
 
       - name: Get latest cmake
         uses: lukka/get-cmake@latest
-
-      - name: set compiler
-        if: matrix.os == 'ubuntu-latest'
+        
+      - name: Configure
+        shell: cmake -P {0}
         run: |
-          echo "CXX=g++-10" >> $GITHUB_ENV
-          echo "CC=gcc-10" >> $GITHUB_ENV
-
-      - name: Configure Linux
-        if: matrix.os == 'ubuntu-latest'
-        run: cmake -DCMAKE_BUILD_TYPE=${{ matrix.config }} --preset gcc-dev  -B build -S .
-
-      - name: Configure Windows
-        if: matrix.os == 'windows-latest'
-        run: cmake -DCMAKE_BUILD_TYPE=${{ matrix.config }} --preset msvc-dev  -B build -S .
+          if ("${{ matrix.compiler }}" STREQUAL "msvc")
+            set(vcpkg_triplet x64-windows)
+            set(compiler_flags "/EHsc /W4")
+          else()
+            set(vcpkg_triplet x64-linux)
+            set(compiler_flags "-Wall -Wextra -Wpedantic -Wconversion -Wshadow")
+            if ("${{ matrix.compiler }}" STREQUAL "gcc")
+              set(ENV{CC} "gcc-13")
+              set(ENV{CXX} "g++-13")
+            else()
+              set(ENV{CC} "clang-15")
+              set(ENV{CXX} "clang++-15")
+            endif()
+          endif()
+          execute_process(
+            COMMAND cmake
+              -S .
+              -B build
+              -D CMAKE_BUILD_TYPE=${{ matrix.config }}
+              -D VCPKG_TARGET_TRIPLET=${vcpkg_triplet}
+              -D "CMAKE_CXX_FLAGS=${compiler_flags}"
+              --toolchain "$ENV{VCPKG_INSTALLATION_ROOT}/scripts/buildsystems/vcpkg.cmake"
+            RESULT_VARIABLE result
+          )
+          if (NOT result EQUAL 0)
+            message(FATAL_ERROR "Bad exit status")
+          endif()
 
       - name: Build
         run: cmake --build build --config ${{ matrix.config }} --parallel
@@ -39,4 +62,4 @@ jobs:
       - name: Publish test report
         uses: mikepenz/action-junit-report@v3
         with:
-          report_paths: 'build/bin/junit_*.xml'
+          report_paths: 'build/junit_*.xml'

vcpkg-configuration.json

@@ -0,0 +1,8 @@
+{
+  "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg-configuration.schema.json",
+  "default-registry": {
+    "kind": "git",
+    "repository": "https://github.com/microsoft/vcpkg",
+    "baseline": "c8696863d371ab7f46e213d8f5ca923c4aef2a00"
+  }
+}