FEATURE: Extract Paragraphs #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I deleted an earlier comment about misunderstanding a Sorbet error. All good for review now! |
yob
reviewed
Nov 18, 2023
There was a problem hiding this comment.
Thanks for the well written submission ❤️
I've been flat out, but I'll try and take a look soon.
It's definitely the case that Page#text isn't very versatile, returning all the text in plain text with no markup.
There is Page#runs which returns a lower level view of the text of a page, including positioning data. I've flip flopped over time on how much I want to add to PDF::Reader directly, and how much I want to encourage folks to build their own code on top of Page#runs. I'll take this for a spin and see how it feels though, cheers!
|
@yob I hope you're well! Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using PDF::Reader at Zipline for parsing content out of PDFs. (I also forked this project on our team repo here.) We have a number of cases where we want to pull out all of the text from multi-column PDF layouts, but PDF::Reader's visually-aligned output via
page.textwas still difficult for us to programmatically parse.I saw that borb has a paragraph extraction feature (code here), and this is my attempt to implement something similar in Ruby.
I'm leaving this in Draft until I can finish the remaining todo items below. Any feedback is appreciated.
To-do: