Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to set a unit for the size of the stick #124

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

erbizard
Copy link

Hi,

I've encountered a problem after using your lib on desktop / mobile.
The problem is the "px" size is not responsive at all so the stick doesn't react the same on all platforms.

I've changed the lib to add a unit / val in the size parameter to allow any unit on the size of the sticks.

The major problem of this update is, if you release this, you need to update major, cause old code with old size isn't supported. and with the typescript I can't make a retro-compatibility.

Regards,
Arthur Rouet

@yoannmoinet
Copy link
Owner

Hi there, thanks for this.

I've encountered a problem after using your lib on desktop / mobile.

Do you have an example somewhere I could check?

@erbizard
Copy link
Author

The problem is the "responsiveness" When you are forced to use px, you can't really make a stick with the same size on every platforms, if you want +-10% on as 1920 * 1080 the size is 190px, but when you test on a mobile 640*360 190 px is like quarter of the screen, so it can be problematic.
And even between different mobiles, there is so many resolution that you can't really have a front that render exactly the same on all mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants