Change default empty output to empty string

ynput · Sep 12, 2024 · 2ee249b · 2ee249b
1 parent ad1599f
commit 2ee249b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/github_query.py b/github_query.py
@@ -143,7 +143,7 @@ def get_version_increment(patch_bump_list: list, minor_bump_list: list, pr_label
     """
 
     if not pr_label_list:
-        return
+        return ""
 
     # TODO add major bump option
     if any(label in pr_label_list for label in minor_bump_list):
@@ -152,4 +152,4 @@ def get_version_increment(patch_bump_list: list, minor_bump_list: list, pr_label
     if any(label in pr_label_list for label in patch_bump_list):
         return "patch"
 
-    return
+    return ""
diff --git a/tests/test_github_query.py b/tests/test_github_query.py
@@ -111,14 +111,14 @@ def test_get_version_increment_minor(minor_bump, patch_bump, pr_labels_enhanceme
 def test_get_version_increment_wrong_labels(minor_bump, patch_bump, pr_labels_wrong_labels):
     increment = github_query.get_version_increment(patch_bump_list=patch_bump, minor_bump_list=minor_bump, pr_label_list=pr_labels_wrong_labels)
 
-    assert increment == None
+    assert increment == ""
 
 def test_get_version_increment_none(minor_bump, patch_bump, pr_labels_none):
     increment = github_query.get_version_increment(patch_bump_list=patch_bump, minor_bump_list=minor_bump, pr_label_list=pr_labels_none)
 
-    assert increment == None
+    assert increment == ""
 
 def test_get_version_increment_ampty_list(minor_bump, patch_bump, pr_labels_empty_list):
     increment = github_query.get_version_increment(patch_bump_list=patch_bump, minor_bump_list=minor_bump, pr_label_list=pr_labels_empty_list)
 
-    assert increment == None
+    assert increment == ""