Farm rendering changes

[antirotor]

Changelog Description

Changes to simplify logic for farm rendering.

Additional review information

If you want to have reviews on farm, you need to add unreal with .* regex here: ayon+settings://deadline/publish/ProcessSubmittedJobOnFarm/aov_filter

Fixes:

• refactored farm rendering flow
• review set on instance
• label in publisher showing folder path

Testing notes:

Warning

You need ynput/ayon-deadline#49 and ynput/ayon-core#958

• create new rendering instance.
• set the render target for Local Rendering
• (render first the images)
• publish - it should publish as expected
• switch the rendering instance to Farm Rendering
• publish - you should have job on farm

[LiborBatek]

The first local render test went smoothly and all good.

But once trying to use farm render it gives me following error in the Publisher:

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\deadline_0.4.0\ayon_deadline\plugins\publish\global\submit_publish_job.py", line 393, in process
    representations = prepare_representations(
                      ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Work\REPO\ayon-core\client\ayon_core\pipeline\farm\pyblish_functions.py", line 336, in prepare_representations
    frames_to_render = _get_real_frames_to_render(frames_to_render)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Work\REPO\ayon-core\client\ayon_core\pipeline\farm\pyblish_functions.py", line 478, in _get_real_frames_to_render
    for frame in frames.split(","):
                 ^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

[moonyuet]

I try to render out and submit to farm, it is rendered successfully.

[moonyuet]

The first local render test went smoothly and all good.

But once trying to use farm render it gives me following error in the Publisher:

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\deadline_0.4.0\ayon_deadline\plugins\publish\global\submit_publish_job.py", line 393, in process
    representations = prepare_representations(
                      ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Work\REPO\ayon-core\client\ayon_core\pipeline\farm\pyblish_functions.py", line 336, in prepare_representations
    frames_to_render = _get_real_frames_to_render(frames_to_render)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Work\REPO\ayon-core\client\ayon_core\pipeline\farm\pyblish_functions.py", line 478, in _get_real_frames_to_render
    for frame in frames.split(","):
                 ^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

you need to test with the PR ynput/ayon-deadline#49 along with the ayon-core mentioned.

[LiborBatek]

@moonyuet I will do! ...it wasnt mentioned within the testing steps...so thanks for letting me know!

[LiborBatek]

Im getting this error when trying to get Layout into UE... I know that its maybe not directly related but I cant do any testing without it actually. The weird thing is, that it even happens in ofical addon versions atm

[moonyuet]

Im getting this error when trying to get Layout into UE... I know that its maybe not directly related but I cant do any testing without it actually. The weird thing is, that it even happens in ofical addon versions atm

i dont think it's related to this PR though. Which unreal version are you testing?