-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence and shot folder grouping #129
base: develop
Are you sure you want to change the base?
Sequence and shot folder grouping #129
Conversation
Creates additional `sequence` subfolder for seq assets to be created.
Only for shots not in sequence, these are added under `sequence/` subfolder.
Special folders 'shot', 'sequence'
Contain 'shot','sequence' values, not real SG entities, they are only attributes there
Contain 'shot','sequence' values, not real SG entities, they are only attributes there
shot and sequence AYON folder doesn't need to store anything as SG_ID >> there is no need to check that value is convertible into int. Last place left might be actually necessary.
Supports multilevel folder structure
Task linked: AY-6666 Shotgrid: sequence and shot folder grouping |
I personally don't think this feature makes much sense. I imagine this comes after this request #126 ? As I commented there, I think it makes sense to group all asset entities under a folder called |
Changes not relevant to this PR.
I am open to ideas how to configure it to be more universal as this is sponsored issue, but I agree it might not apply to all use cases, same as yours doesn't. |
So where are shots parented to sequences go? Or a sequence child of an episode and that episode having sequences and then shots? Could you put some examples of the different cases? |
I'm so clueless about these conversations - doesn't shotgrid just have hierarchies itself? And shouldn't we just adhere to that hierarchy 1:1? Or what makes this so complex? |
Yeah I'm a bit confused too tbh, I thought the request was to have it just on disk (which wouldn't require to create the entities in the server and it's just a template thing) and just as a means to encapsulate ALL of the shots (with its respective hierarchy) within. On the other hand, if they want those categories to show up on the UIs that's something we can do in the frontend agnostic of shotgrid as the folder types exist, it's basically just an extension to the existing icons? |
Previously used only Studio settings
This allows to separate each Asset/Shot/Sequence into separate hiearchies.
2 workflows - root relocate - put hierarchy to AYON only additional folders - type grouping - all shots/sequences/assets together separately
Dont have access to `sg_asset` in code
Code was removed during refactor erroneously
Pushes/updates AYON entity id to matching SG entity
It should always start from project_entity and add layers.
New ayon_python_api has modified arguments
… enhancement/AY-6666_Shotgrid-sequence-and-shot-folder-grouping
Removed from underlying call, not necessary here anymore
Removed from underlying call, not necessary here anymore
Tasks don't have data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both methods work fine for me. For some reason there is a one minute delay (waiting) between pressing the Sync button (SG -> AYON) since the Processor service begin to do something, lets see if this can be improved.
Changelog Description
Synchronized
sequences
andshots
were stored directly in root of the AYON project previously. This PR adds configurable option to set mainassets
,sequences
andshots
subdirectories.Additional info
Previously
seq0
would be directly next toenvironment
, without wrappingsequences
folderThere might be discussion needed for current implementation of
shots
without sequences in SG (if it makes actually sense in production). I implemented it according to requirements, but it might be just misunderstanding.! For running projects
ayon+settings://shotgrid/compatibility_settings/folder_locations
should be purged to keep original implementation. (Or maybe changed defaults OR changed initialization of this addon???)Implemented 2 workflows:
This will reparent all SG
Assets
underassets
category, all Sequences and their Shot children undersequences
.Resulting in:
##############################
Second use case
Will separate SG
Assets
into AYONassets
, SGSequences
intosequences
,Shots
into/shots/new_shots
Resulting in:
Testing notes:
ayon+settings://shotgrid/compatibility_settings/folder_parenting
if it matches your requirementsshots
folder is for shots without sequences (which is possible in SG)