-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AY-979 Finalize updating Resolve to new publisher #15
AY-979 Finalize updating Resolve to new publisher #15
Conversation
- Removed the function for loading stylesheets in the menu. - Refactored plugin creation logic to use new API methods and data structures.
…ed content related to previous versions.
- Refactored function names and descriptions for clarity - Added new function to export timeline otio files - Improved temporary directory handling for otio files
Adjusted get_otio_temp_dir to set timeline if not provided, throwing error if none found.
Co-authored-by: Roy Nieterau <[email protected]>
Task linked: OP-8066 Resolve: update to new publisher |
@jakubjezek001 I've addressed your feedback regarding the Regarding your question about handles workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works fine as expected! Great work @robin-ynput - we can merge this but lets wait also for the merge of ynput/ayon-core#916 and ideally after it is released, so we could change the dependent core version in ayon-resolve\package.py
under ayon_required_addons.
DONE:
|
It looks like the linked issue might have been added by mistake. Is it correct? After a quick look at the changes, it seems that the suggested changes from issue #2 weren't applied. |
This is not a mistake, I've tested all of the work on Windows with OTIO 0.17.0 and 0.16.0 it works. So the issue described on this issue has been fixed but with another approach than the suggested change on the ticket (wrapper function + enforce documentation so people use 0.15.0 version). EDIT: confirmed it works with 0.17.0, 0.16.0, 0.15.0, 0.14.0 and 0.13.0 |
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Update imports, add new function parameter 'task' to get_editorial_publish_data, refactor tag metadata creation in CreateEditorialPackage, handle backward compatibility for missing data fields in instances, and update metadata handling in LoadEditorialPackage and CreateEditorialPackage.
Co-authored-by: Roy Nieterau <[email protected]>
…e_new_publisher Transfer editorial package to new publisher
Changelog Description
Finishes up with Resolve switch to new Publisher.
Finishes up the features that were already implemented in ynput/ayon-core#157
- primary:
shot
- instance with hierarchy, future context data and attributes placeholder- secondary:
plate
,audio
,review
- instance with mediaopentimelineio >= 0.16.0
Testing notes:
In Resolve:
Workspace -> Script -> AYON Menu
Tested locally on Windows with Resolve
19.0, 18.5
and OpenTimelineIO0.17.0, 0.16.0
.