Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-979 Finalize updating Resolve to new publisher #15

Merged
merged 67 commits into from
Oct 8, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Aug 28, 2024

Changelog Description

Finishes up with Resolve switch to new Publisher.
Finishes up the features that were already implemented in ynput/ayon-core#157

  • - @BigRoy suggested warning message if there is not anything to be used for creation
  • - @BigRoy flagged that when clicking Create for Create Publishable Clip but there's no valid clips in timeline nothing happens
  • - @BigRoy flagged that previous creators was creating instances with invalid folder path(s)
  • - @BigRoy flagged issues when deleting instances in the creator
  • - Spliting product types into:
    - primary: shot - instance with hierarchy, future context data and attributes placeholder
    - secondary: plate, audio, review - instance with media
  • - Hierarchy and context data should be linked from Shot instance for all secondary product types Traypublisher (TP)
  • - Each secondary product type which will be created from a clip should have own creator class - like in TP
  • - When possible OTIO export should be done via native function rather then our implementation
  • - OTIO support for opentimelineio >= 0.16.0
  • - Ensure that audio cannot be exported from non-audio timeline(s)
  • - Test out with Resolve 19
  • - Help description in "?" button
  • - Fix review product not published when review_track contains a space
  • - Update client/README documentation

Testing notes:

In Resolve:

  1. Create a timeline with clips associated to a media
  2. (Optional) Make a selection coloring some clips in Chocolate color
  3. From Workspace -> Script -> AYON Menu
  4. Create and publish product(s) of type shot, audio, plate and review from there

Tested locally on Windows with Resolve 19.0, 18.5 and OpenTimelineIO 0.17.0, 0.16.0.

@ynbot
Copy link
Contributor

ynbot commented Aug 28, 2024

Task linked: OP-8066 Resolve: update to new publisher

@robin-ynput robin-ynput self-assigned this Aug 28, 2024
@robin-ynput robin-ynput added the type: enhancement Improvement of existing functionality or minor addition label Aug 28, 2024
@robin-ynput robin-ynput linked an issue Aug 28, 2024 that may be closed by this pull request
2 tasks
@robin-ynput robin-ynput marked this pull request as draft August 28, 2024 19:36
@robin-ynput robin-ynput marked this pull request as ready for review August 28, 2024 22:53
@robin-ynput
Copy link
Contributor Author

@jakubjezek001 I've addressed your feedback regarding the has_promised_context. Thanks for that.
adjusted_feedback_resolve

Regarding your question about handles workflow.
So, I have never been an editor myself and always was on the tooling side, but I don't recall any dynamic/min handles workflow.
As far as I can remember, Editors were creating shots in Ftrack/Shotgrid with handles defined from client specs document and keep it consistent per shot.
So the logic we have in extract_otio_review (extra from media if available or generate black frames otherwise) is what I am more used to.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine as expected! Great work @robin-ynput - we can merge this but lets wait also for the merge of ynput/ayon-core#916 and ideally after it is released, so we could change the dependent core version in ayon-resolve\package.py under ayon_required_addons.

@robin-ynput
Copy link
Contributor Author

robin-ynput commented Oct 2, 2024

DONE:

@jakubjezek001
Copy link
Member

It looks like the linked issue might have been added by mistake. Is it correct? After a quick look at the changes, it seems that the suggested changes from issue #2 weren't applied.

@robin-ynput
Copy link
Contributor Author

robin-ynput commented Oct 7, 2024

It looks like the linked issue might have been added by mistake. Is it correct? After a quick look at the changes, it seems that the suggested changes from issue #2 weren't applied.

This is not a mistake, I've tested all of the work on Windows with OTIO 0.17.0 and 0.16.0 it works.
I'll do other attempt with 0.15.0 and 0.13.0 to be 200% sure.

So the issue described on this issue has been fixed but with another approach than the suggested change on the ticket (wrapper function + enforce documentation so people use 0.15.0 version).

EDIT: confirmed it works with 0.17.0, 0.16.0, 0.15.0, 0.14.0 and 0.13.0

robin-ynput and others added 16 commits October 7, 2024 10:52
Update imports,
add new function parameter 'task' to get_editorial_publish_data,
refactor tag metadata creation in CreateEditorialPackage,
handle backward compatibility for missing data fields in instances,
and update metadata handling in LoadEditorialPackage and CreateEditorialPackage.
…e_new_publisher

Transfer editorial package to new publisher
@robin-ynput robin-ynput merged commit 249b0a3 into develop Oct 8, 2024
1 check passed
@robin-ynput robin-ynput deleted the feature/AY-979_finish_Resolve_new_publisher branch October 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration fails on publishing with recent OpenTimelineIO versions (0.16.0+)
5 participants